music-manager.rb: do not move prefpane

[vitorgalvao]

Editing an existing cask

• Commit message includes cask’s name (and new version, if applicable).
• brew cask audit --download {{cask_file}} is error-free.
• brew cask style --fix {{cask_file}} left no offenses.

Why would we be taking it? Presumably the app will take care of it.

[tjanson]

See #20405:

The app will copy the pref pane itself on first run (if it does not already exist), but then brew uninstall will not remove it.
By letting brew symlink the pref pane, it uninstalls properly.

[tsparber]

@tjanson Would a uninstall delete: '~/Library/Preference Panes/MusicManager.prefPane' also work in this case?

[vitorgalvao]

@tjanson I was going to suggest what @tsparber just mentioned. As to why I’m removing this, see #21657 (comment). Since we now move instead of linking, this current cask essentially modifies the app (since it removes the prefpane from inside) which isn’t good at all.

[tjanson]

This should be ~/Library/PreferencePanes/… (no space), right?

[tsparber]

I just used the path from man brew-cask without checking. Turns out this needed some fixing (#21670).

[tjanson]

Ah, cool to see that the move to move has been made. 👍
Removing the pane during uninstall works for me, but the path is "~/Library/PreferencePanes/MusicManager.prefPane".