Fix template checker sync#443
Merged
Merged
Conversation
- Keep `check_template.rb` owned by `Homebrew/.github` instead of syncing it into target repositories. - Fetch the checker from `Homebrew/.github` in synced workflows so targets use shared trusted code. - Remove stranded checker copies from synced target repositories.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the “template checker” distribution model so check_template.rb remains centrally owned in Homebrew/.github, while synced workflows in target repositories fetch and run that shared checker, and any previously-synced copies in targets are removed.
Changes:
- Update
check-prs.ymlandcheck-issues.ymlto fetchcheck_template.rbfromHomebrew/.githubinstead of from the target repository. - Adjust the sync logic to stop syncing
check_template.rbinto target repositories and instead remove any existing copies. - Ensure the
.githubrepository itself retains its localcheck_template.rb(not deleted by sync).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/check-prs.yml | Fetches the template checker script from Homebrew/.github for PR template validation. |
| .github/workflows/check-issues.yml | Fetches the template checker script from Homebrew/.github for issue template validation. |
| .github/actions/sync/shared-config.rb | Stops syncing check_template.rb into targets and removes any copies during sync runs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
p-linnane
approved these changes
Jun 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check_template.rbowned byHomebrew/.githubinstead of syncing it into target repositories.Homebrew/.githubin synced workflows so targets use shared trusted code.