Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#128 H] Trips #26

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

[#128 H] Trips #26

wants to merge 21 commits into from

Conversation

tillwenke
Copy link
Member

@tillwenke tillwenke commented Feb 7, 2025

relates to bopjesvla#128

I only introduce the necessary db changes here and basic functionality to interact with and create trips.

Everything beyond that should be done in a follow-up UX PR.

@tillwenke tillwenke self-assigned this Feb 7, 2025
@leon-wbr leon-wbr marked this pull request as draft February 8, 2025 11:23
@tillwenke tillwenke requested review from leon-wbr and removed request for leon-wbr February 8, 2025 11:37
@leon-wbr leon-wbr changed the title [H-128] Trips [#128 H] Trips Feb 8, 2025
@bopjesvla
Copy link

Everything beyond that should be done in a follow-up UX PR.

Risky business. Maybe collaborate with someone on this? UX things don't tend to happen on their own, and it's easier to implement something from scratch than to update someone else's reference implementation.

@leon-wbr
Copy link
Collaborator

leon-wbr commented Feb 9, 2025

This PR will take a little bit longer to merge, I'd like to join in on this and contribute to it. Alright for you, @tillwenke?

@tillwenke
Copy link
Member Author

tillwenke commented Feb 9, 2025

This PR will take a little bit longer to merge, I'd like to join in on this and contribute to it. Alright for you, @tillwenke?

I believe this pr is pretty self-contained and large enough. I d rather complete it first and everything else can be done in a follow up pr. the current functionality is minimal but still sufficient (by that I mean anyone using it as it is wont do any harm playing around with it) - we will not draw the users attention towards /trips yet.

This enables us to play around with and test it in production e.g. to see how we like the automatically generated trips - it is easiest to understand this with your own reviews liked to your account in prod. If you have to test it locally I can recommend creating a user "Chris9012"

I opened a follow up pr here #33

@tillwenke tillwenke marked this pull request as ready for review February 9, 2025 16:56
@tillwenke tillwenke requested a review from leon-wbr February 9, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants