Revert "Replaces intents with combat mode (#56601)" #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…humanized (#57824) * Fixes mind magnified monkey humanization * Update helmet.dm
… tab. (#57882) About The Pull Request Currently admins can't access the ticket logs for Resolved, Disconnected, Closed and Active tickets due to an early return that will block these from being opened in 100% of circumstances. Clicking on the Active/Disconnected/Closed/Resolved tickets would have behaviour handled by /datum/admin_help_tickets/proc/BrowseTickets() which was reached through Click() calls. image When we call .Click() from topic calls, we provide a null var for the control parameter. This then leads through to /client/Click() where #57084 added a bunch of if(!control) checks supposedly ported from TGMC (or at least Fikou couldn't explain why we changed that). I can't find a single instance of us using this locally, it appears it's always passed through to Byond. Byond docs at http://www.byond.com/docs/ref/#/client/proc/Click describe it as control - the name of the skin control involved I can't see any reason to early return if control is a FALSE-y value. This check is what was blocking access to the admin_help_tickets datum. In testing, removing these checks restored previous functionality. Why It's Good For The Game Admins less triggered. Changelog 🆑 fix: Admins can once again open the stat panels to look at active, disconnected, closed and resolved tickets. /🆑
…t to a variable (#57878)
…on (#57864) * banished * drop loc
…rtment (#57877) Fixes #57869 - Sec officers now only get PDA'd if the new member is of the same department
imageadd: New bio hood sprites.
* heat pump rework * f * efficiency * powe * powermess * better math * math and enviroment equation * freezers connected to waste pipenet and co2 recircled in waste * smol * rotate danger * upgrades * minor tweaks * requested changes
#57593 added CQC whitelists to each map, but the whitelisted area on Icebox (/area/service/kitchen/tourist_seating_area)... doesn't exist. This changes that area to the actually used area.
Each of these lines is punctuated by an audio sting every 8 seconds without refrain. So, this PR adds a new vocalisation limiter to tourist bots who can't find a seat. Instead of always vocalising every 8 seconds, they're now guaranteed to vocalise the first time and then have a 60% chance to have vocalised again each minute thereafter. Tourists waiting for food now have an approx 40% chance to have vocalised in any given minute. This should be considered alongside the fact that multiple (up to 10) tourists can be present at any given point in time and with the difficulty in players killing them, they can create a lot of unnecessary audio spam. If the tourists are being served rapidly, they're also giving regular guaranted audio stings on top of that which compounds the chances any given bot will output an audio cue. The AI controller now passes the larger value between the behaviour's `action_cooldown` in real seconds (as opposed to deciseconds) and delta_time when performing behaviours. This has no gameplay changes outside of those documented in this PR, since no AI behaviours with cooldowns greater than the AI controller's delta_time attempted to use delta_time. Finally, customers now have 10 minutes of patience before leaving instead of 100 minutes of patience due to a minor oversight where their patience was in deciseconds while delta_time was subtracted in seconds.
Removes and/or updates some more tips that #57927 missed.
* Preliminary popper support * Switch tooltips to popper.js * Documentation, change DEFAULT_PLACEMENT
Gives admins control of how many antags they spawn, instead of assuming a maximum of (generally) 3. image
…an issu with jungle fever (#57897) Co-authored-by: Mothblocks <[email protected]>
…w how I missed this (#57973)
Co-authored-by: MLGTASTICa <[email protected]>
This reverts commit 707fc28.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 707fc28.