Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add file api design(add to wishlist) #24

Open
wants to merge 4 commits into
base: staging
Choose a base branch
from

Conversation

obeidahr
Copy link

No description provided.

@haithamalnaeb
Copy link
Contributor

Thank you @obeidahr for your PR
good start,

There are some notes to take care of:

  • you don't to create new file, move your code to apis.yaml and delete [API Design] add to wishlist.yml file.
  • it would be great to re-read API Spec's contributing guideline and confirm your code.
  • you should use /wishlist/{productId} endpoint, with POST method for add
  • you only need to define productId parameter, in path, as int, no need for requestBody
  • your 200 response does not have to return content (there is nothing to return except status code 200)

Please replay if you see any point is not logical, you can also discuss it in the group chat.

@haithamalnaeb
Copy link
Contributor

Thank you @obeidahr
you are getting better 👍

however, we still need to add productId in path as /wishlist/{productId}
and use the method POST (for adding) instead of put (for update)
and use tags: wishlist instead of user
and add parameters like in delete from wisthlist
and finally, move components: section to the left one step (two spaces)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants