Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a generator that converts the json file into the README.md file #22

Merged
merged 4 commits into from
Dec 2, 2017

Conversation

Andy-set-studio
Copy link
Contributor

About this PR

I've made a little generator with node that will convert the checklist.json file into README.md. It's bare-bones ES5 to make sure it's as easy to run as possible. The only prerequisite is that the user has node installed on their machine.

I also split the readme up by creating intro.md. This is so we can continue to manage the content of it in a reasonable fashion.

To run the generator, run: node generator/index.js

- Break the intro off the readme file so that we can still manage it
- Create a generator to do the hard work for us
- Allow for multiple resources per item by looping and generating links
@Andy-set-studio Andy-set-studio changed the title Feature/create md generator Create a generator that converts the json file into the README.md file … Nov 29, 2017
@Andy-set-studio Andy-set-studio changed the title Create a generator that converts the json file into the README.md file … Create a generator that converts the json file into the README.md file Nov 29, 2017
- [ ] Use textual labels to make voice activation cues obvious
- [ ] Do not mark up subheadings/straplines with separate heading elements
- [ ] Ensure primary calls to action are easy to recognize and reach
- [ ] Avoid images of text — text that cannot be translated, selected, or understood by assistive tech
- [ ] Provide a print stylesheet (single column, with interactive content hidden)
- [ ] Use well-established, therefore recognizable, icons and symbols
- [ ] Subset fonts to just the characters needed
- [ ] Instead of obstructing users with CAPTCHAs, use [honeypots](https://en.wikipedia.org/wiki/Honeypot_(computing))
- [ ] Instead of obstructing users with CAPTCHAs, use [honeypots [Resource #1](https://en.wikipedia.org/wiki/Honeypot_(computing))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to be an extra [ here

Copy link

@peter-mouland peter-mouland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! but looks like a couple some minor tweaks are needed (see comments)

- [ ] Begin long, multi-section documents with a table of contents
- [ ] Don't make users perform actions to reveal content unless completely necessary
- [ ] Don"t make users perform actions to reveal content unless completely necessary

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure " is necessary :)

@Andy-set-studio
Copy link
Contributor Author

@peter-mouland, Yeh they're all from checklist.json, so that could do with a tidy up :)

@Heydon
Copy link
Owner

Heydon commented Dec 2, 2017

@hankchizljaw Not clear on the status of this pull request. Can I merge or are you still tweaking?

@Andy-set-studio
Copy link
Contributor Author

Yeh the generator is good to go mate. I think we could tackle the pre-commit in a separate PR.

I think we could work out how to integrate and the pre-commit as a group. I started off a bit of a discussion in #1. We should probably split out into another issue though?

@Heydon
Copy link
Owner

Heydon commented Dec 2, 2017

@hankchizljaw Sounds good (the new issue I mean)

@Heydon Heydon merged commit 9e57811 into Heydon:master Dec 2, 2017
@Andy-set-studio
Copy link
Contributor Author

I’ve started a new discussion in #23. Thanks for merging the code in, @Heydon! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants