-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a generator that converts the json file into the README.md file #22
Create a generator that converts the json file into the README.md file #22
Conversation
- Break the intro off the readme file so that we can still manage it - Create a generator to do the hard work for us - Allow for multiple resources per item by looping and generating links
- [ ] Use textual labels to make voice activation cues obvious | ||
- [ ] Do not mark up subheadings/straplines with separate heading elements | ||
- [ ] Ensure primary calls to action are easy to recognize and reach | ||
- [ ] Avoid images of text — text that cannot be translated, selected, or understood by assistive tech | ||
- [ ] Provide a print stylesheet (single column, with interactive content hidden) | ||
- [ ] Use well-established, therefore recognizable, icons and symbols | ||
- [ ] Subset fonts to just the characters needed | ||
- [ ] Instead of obstructing users with CAPTCHAs, use [honeypots](https://en.wikipedia.org/wiki/Honeypot_(computing)) | ||
- [ ] Instead of obstructing users with CAPTCHAs, use [honeypots [Resource #1](https://en.wikipedia.org/wiki/Honeypot_(computing)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems to be an extra [
here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! but looks like a couple some minor tweaks are needed (see comments)
- [ ] Begin long, multi-section documents with a table of contents | ||
- [ ] Don't make users perform actions to reveal content unless completely necessary | ||
- [ ] Don"t make users perform actions to reveal content unless completely necessary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure "
is necessary :)
@peter-mouland, Yeh they're all from |
@hankchizljaw Not clear on the status of this pull request. Can I merge or are you still tweaking? |
Yeh the generator is good to go mate. I think we could tackle the pre-commit in a separate PR. I think we could work out how to integrate and the pre-commit as a group. I started off a bit of a discussion in #1. We should probably split out into another issue though? |
@hankchizljaw Sounds good (the new issue I mean) |
About this PR
I've made a little generator with node that will convert the
checklist.json
file intoREADME.md
. It's bare-bones ES5 to make sure it's as easy to run as possible. The only prerequisite is that the user has node installed on their machine.I also split the readme up by creating
intro.md
. This is so we can continue to manage the content of it in a reasonable fashion.To run the generator, run:
node generator/index.js