Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Clarify the keyboard focus warning" #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Heydon
Copy link
Owner

@Heydon Heydon commented Aug 17, 2014

Reverts #7

@Heydon
Copy link
Owner Author

Heydon commented Aug 17, 2014

I think you're onto something here. However, ([tabindex]) should probably be concatenated with :not([tabindex="-1"]) ?

@denis-sokolov
Copy link
Contributor

Well, that would be a further improvement to my change. I wouldn't go as far as to revert it.
Perhaps even have a separate rule:

button[tabindex="-1"], a[tabindex="-1"], .btn[tabindex="-1"], .button[tabindex="-1"], input[tabindex="-1"] {
}

P.S. Mention a developer to invite him to join a discussion. I got to know about this pull request by accident.

@Heydon
Copy link
Owner Author

Heydon commented Aug 17, 2014

@denis-sokolov like this? Yeah, sorry :-)

The trouble is tabindex="-1" is focusable programmatically. In some ARIA widgets, -1 on links or buttons is necessary for turning tabbing off before adding custom key controls like arrow keys (?)

@denis-sokolov
Copy link
Contributor

Well, then just leave it as it is.
If somebody has explicitly chosen to add tabindex="-1", I don't think they need a warning about the element being unfocusable.

Copy link

@missfoti72 missfoti72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crashed web sites

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants