This repository has been archived by the owner on Apr 13, 2024. It is now read-only.
Implement a which built-in
#68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We sometimes want to look-up a command without actually executing it, so the parsing is unnecessary work.
lookupAll() takes the same arguments as lookup(), but returns either undefined or an array of matching commands. Our existing CommandProviders will only ever produce a single result, but this will not be the case for reading executables from PATH.
CommandProviders can expose this by setting the 'path' field of the object they return from execute(). If 'path' is not set, we assume that the command is a shell built-in. Scripts set their 'path' to be the same as the path used to access them, which matches the behaviour I'm seeing on Linux.
|
a bit of merge backlog due to upcoming backend release 😅 - this one is pretty straightforward, merging it |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whichlets you query which executable will be run for a given command. This is not yet especially useful, because everything is either a built-in or a script file, but we should have PathCommandProvider working soon. :^)