-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes #7 Beatrix-droid removed hard coded paths to files #8
base: main
Are you sure you want to change the base?
fixes #7 Beatrix-droid removed hard coded paths to files #8
Conversation
hey this doesn't work on windows environment. try using (images/image_name) |
updated path files as requested by the comment in my previous pr
I have updated the PR to reflect the changes you asked for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey, I had a check its not working in windows but (images//limage_name) is working. could you wheater it works on Linux too?
I have checked it works! |
Removed unnecessary imports and used the OS module to remove all instances of hard coded paths to files, as some paths were hard coded for windows computers and wouldn't have worked on Unix or Unix like systems.
With this layer of abstraction, the app now runs on linux, and should be able to run on windows as well, as no values are hardcoded.
Test the app and let me know if it works on windows too