Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #7 Beatrix-droid removed hard coded paths to files #8

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Beatrix-droid
Copy link

Removed unnecessary imports and used the OS module to remove all instances of hard coded paths to files, as some paths were hard coded for windows computers and wouldn't have worked on Unix or Unix like systems.
With this layer of abstraction, the app now runs on linux, and should be able to run on windows as well, as no values are hardcoded.
Test the app and let me know if it works on windows too

@Beatrix-droid Beatrix-droid changed the title fixes #4 Beatrix-droid removed hard coded paths to files fixes #7 Beatrix-droid removed hard coded paths to files Jul 15, 2022
@HeyAnirudh
Copy link
Owner

Removed unnecessary imports and used the OS module to remove all instances of hard coded paths to files, as some paths were hard coded for windows computers and wouldn't have worked on Unix or Unix like systems. With this layer of abstraction, the app now runs on linux, and should be able to run on windows as well, as no values are hardcoded. Test the app and let me know if it works on windows too

hey this doesn't work on windows environment. try using (images/image_name)

updated path files as requested by the comment in my previous pr
@Beatrix-droid
Copy link
Author

Removed unnecessary imports and used the OS module to remove all instances of hard coded paths to files, as some paths were hard coded for windows computers and wouldn't have worked on Unix or Unix like systems. With this layer of abstraction, the app now runs on linux, and should be able to run on windows as well, as no values are hardcoded. Test the app and let me know if it works on windows too

hey this doesn't work on windows environment. try using (images/image_name)

I have updated the PR to reflect the changes you asked for

Copy link
Owner

@HeyAnirudh HeyAnirudh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey, I had a check its not working in windows but (images//limage_name) is working. could you wheater it works on Linux too?

@Beatrix-droid
Copy link
Author

I have checked it works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants