[Dist] set the correct WM Class in the flatpak Desktop Entry #4181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This hints to the DE that the application only supports one "main" window. In GNOME, this prevents the DE adding a useless "New Window" button.
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
This comment was marked as resolved.
This comment was marked as resolved.
13 tasks
Etaash-mathamsetty
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
also make a PR here: https://github.com/flathub/com.heroicgameslauncher.hgl
Sure thing, done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on Discord, the WM Class is incorrect in the Desktop Entry.
For whatever reason this has not caused problems in the flatpak itself, likely because flatpak or the DE is able to deduce that there is only one desktop entry and one app in the flatpak?
Downstream
However for downstream packages that use this file as a base template, this subtle inconsistency can lead to issues.
See NixOS/nixpkgs#365460 for example.
Downstream, the window is untracked due to the wmclass mismatch:
Without that PR:
With that PR:
Single "main" window
I've also set
SingleMainWindow=true. This is a new key added in Desktop Entry Spec v1.5. It acts as a hint to the DE regarding whether this is a single-window app (not counting things like child windows). For instance, it hints at whether a "New Window" button would make sense.In GNOME we see exactly that:
(screenshot from another project where I was playing with the same thing)
Flathub
Mirror PR: flathub/com.heroicgameslauncher.hgl#181
Use the following Checklist if you have changed something on the Backend or Frontend: