-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Remove sideloaded games from recent list when uninstalled #4178
base: main
Are you sure you want to change the base?
Conversation
@@ -128,6 +129,7 @@ export async function uninstall({ | |||
notify({ title, body: i18next.t('notify.uninstalled') }) | |||
|
|||
removeShortcutsUtil(gameInfo) | |||
removeRecentGame(appName) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you add awaits and await removeNonSteamGame({ gameInfo })
as well ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand we intentionally don't await for these things, they can happen async and makes it faster
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could still wrap 'em in an await Promise.all([ ... ])
to at least run them in parallel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aren't those already running in parallel? I think we really don't care about waiting for the result of those calls at all
is there any benefit I'm missing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it would be better if everything was removed by the time this function returned, but it's not necessary. Also the other uninstall functions use awaits
We have an issue that we can only manually remove elements from the recent list in the tray icon when they are either installed or part of the games in the library, but uninstalled sideloaded games disappear completely.
This PR doesn't fix the full problem but I think it's good enough for most use cases:
To clean the list with already old elements, we can instruct users to edit the file at
~/.config/heroic/store/config.json
and remove elements they don't want from the"recent"
key.Fixes #4170
Use the following Checklist if you have changed something on the Backend or Frontend: