[UX] UMU used by default if linux and proton, not exprimental anymore, allow disabling as needed #4175
+81
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielj
requested review from
a team,
flavioislima,
CommandMC,
Nocccer and
imLinguin
and removed request for
a team
arielj
commented
Dec 14, 2024
| if (gameSettings.wineVersion.type !== 'proton') return false | ||
| if (gameSettings.disableUMU) return false | ||
| if (!checkUmuInstalled) return true | ||
| if (!existsSync(await getUmuPath())) return false |
There was a problem hiding this comment.
I'm using individual returns for each condition cause I think it's easier to understand what's being checked and we can avoid more expensive operations if we can return earlier
CommandMC
reviewed
Dec 14, 2024
CommandMC
approved these changes
Dec 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UMU has been experimental for a while now and it's been working fine for some time already (the issue with the steamdeck in gaming was solved, and the issue with winetricks was solved too).
This PR changes 3 things:
Once this is merged we could change the Wine Manager screen to recommend Proton-GE instead of Wine-GE.
Use the following Checklist if you have changed something on the Backend or Frontend: