Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: egs-sync path field is always disabled #4174

Merged
merged 1 commit into from
Dec 14, 2024
Merged

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Dec 14, 2024

We have the logic backwards, it should be editable when NOT isSyncing (current logic makes it always disabled cause isSyncing starts as false)


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Dec 14, 2024
@arielj arielj requested review from a team, flavioislima, CommandMC, Nocccer and imLinguin and removed request for a team December 14, 2024 01:08
@arielj arielj merged commit 8e8e805 into main Dec 14, 2024
9 checks passed
@arielj arielj deleted the fix-disabled-egs-sync branch December 14, 2024 03:02
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Dec 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants