Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS Dock Menu support #4158

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

LenaWil
Copy link

@LenaWil LenaWil commented Dec 5, 2024

Implements support for macOS Dock Menus.

Original text:
A terrible two liner that I didn’t put through the linter to show that support for Dock Menu’s would be easy to implement.

I should probably improve it, but I first wanted to know if the devs are open to this at all before I actually spend time on this.

Closes #4156.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@flavioislima
Copy link
Member

flavioislima commented Dec 5, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@LenaWil
Copy link
Author

LenaWil commented Dec 5, 2024

I have read the CLA Document and I hereby sign the CLA

(I should have looked at that import statement)
@LenaWil
Copy link
Author

LenaWil commented Dec 5, 2024

The linting is failing because of http errors, not actual errors. Can someone rerun it when the servers are up again?

@LenaWil LenaWil changed the title Concept macOS Dock Menu support macOS Dock Menu support Dec 6, 2024
@LenaWil
Copy link
Author

LenaWil commented Dec 7, 2024

Repeating something I said on Discord:
Also I could make a separate menu for the Dock with the stop/quit option hidden, that would mean generating the menu twice though.

@Etaash-mathamsetty Etaash-mathamsetty added the pr:ready-for-review Feature-complete, ready for the grind! :P label Dec 14, 2024
@CommandMC CommandMC requested review from a team, arielj, flavioislima, CommandMC, Nocccer and imLinguin and removed request for a team December 14, 2024 10:54
@CommandMC
Copy link
Collaborator

Adding this image posted on Discord to make it easier to picture how this looks for people on non-macOS:
image

Copy link
Collaborator

@CommandMC CommandMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't test this, but looks and sounds fine to me

src/backend/tray_icon/tray_icon.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dock Menu on macOS
4 participants