Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snap: initial manifest and fixes #4091

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

soumyaDghosh
Copy link

@soumyaDghosh soumyaDghosh commented Nov 3, 2024

This is the initial manifest. I have also created a patch to get the actual release details of the OS. If you want, I can also create a PR for the build and release.

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@flavioislima
Copy link
Member

flavioislima commented Nov 3, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@soumyaDghosh
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@flavioislima
Copy link
Member

@soumyaDghosh can you run yarn prettier-fix to fix linting?

How can we build it locally? it is enough to setup snapcraft and run the build command from the snap directory?

@flavioislima flavioislima added the pr:ready-for-review Feature-complete, ready for the grind! :P label Nov 10, 2024
@soumyaDghosh
Copy link
Author

soumyaDghosh commented Nov 10, 2024

@soumyaDghosh can you run yarn prettier-fix to fix linting?
I did, and it's still fixing the linter.

How can we build it locally? it is enough to setup snapcraft and run the build command from the snap directory?

Yup simple setup snapcraft and build from the project's root directory.

@CommandMC
Copy link
Collaborator

(note that it's pnpm prettier-fix, although Yarn would probably still work)

@soumyaDghosh
Copy link
Author

pnpm prettier-fix

I don't think the lint is failing due to my PR

@hifron
Copy link

hifron commented Dec 15, 2024

[Lint code.: src/backend/shortcuts/shortcuts/shortcuts.ts#L178](https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/pull/4091/files#annotation_28849852869)
This assertion is unnecessary since it does not change the type of the expression

also pnpm has a lot of bugs as it is not so mature like for electron app includes of modules

@CommandMC
Copy link
Collaborator

I don't think the lint is failing due to my PR

The changes made in this PR also cause the lint to fail. We've had a brief issue where un-linted code got into the main branch, but this was resolved. Please

  1. rebase/merge on main
  2. run pnpm lint --quiet and pnpm prettier locally to find problematic code
  3. fix the errors found in (2)

also pnpm has a lot of bugs as it is not so mature like for electron app includes of modules

The issue you're referencing there is 3 years old, being resolved 2 years ago. pnpm works fine for Electron projects (most of the time working OOTB, with this repo requiring the config change mentioned in the issue)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants