Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Show 'import game' hint/instructions in 'add game' dialog #3940

Merged
merged 2 commits into from
Dec 14, 2024

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Aug 11, 2024

This PR adds a small InfoBox at the top of the Add Game dialog to tell the users that if they are trying to add an Epic/GOG/Amazon game they own from a store, they should actually use the Import Game feature.

image

image

it's small so it's not too invasive for the people that understand the difference, but hopefully it gets the attention of new users and prevents them from using Add Game when they actually want to import.

Closes #3902


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Aug 11, 2024
@arielj arielj changed the title Show 'import game' hint/instructions in 'add game' dialog [UX] Show 'import game' hint/instructions in 'add game' dialog Aug 26, 2024
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Interesting feature. Perhaps mention something about malmwares and viruses?

@arielj
Copy link
Collaborator Author

arielj commented Dec 2, 2024

Looks good. Interesting feature. Perhaps mention something about malmwares and viruses?

What do you mean to mention something about malwares and viruses?

The objective of this message it to tell users to use the Import Game feature when adding a game from epic/gog/amazon that's already installed by another method. Not sure what to mention related to malwares.

@arielj arielj force-pushed the feature/instruct-about-importing-game branch from d1600be to b4e6211 Compare December 14, 2024 02:47
@arielj arielj merged commit 73f295c into main Dec 14, 2024
8 of 9 checks passed
@arielj arielj deleted the feature/instruct-about-importing-game branch December 14, 2024 02:57
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Dec 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In the Add Game dialog, show a message telling users about the Import Game option
2 participants