-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EPIC]: Support third-party managed applications #3763
Conversation
this allows for EA games to be installed with Heroic, the EA App will be downloaded and installed accordingly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's working good, I'll continue testing more games but all good so far
I added minor comments
src/frontend/screens/Library/components/InstallModal/ThirdPartyDialog/index.scss
Outdated
Show resolved
Hide resolved
I tested the 4 ea games I have (star wars squadrons, star wars battlefront 2, dragon age, sims 4) and they all worked with this (for dragon age I needed the legendary build with the fix form the legendary repo too) I had some issue with squadrons but that was unrelated to heroic (it wouldn't finish the installation with wine-ge for me, so I had to install the game using wine-staging -that failed to run- and then switch to wine-ge, I'm testing if everything works with proton) not sure if someone else wants to review/test this but it's working (maybe in the future we could check some things like allowing importing the game, but I don't think we need to worry about that at this point) |
I think the only thing I was expecting to happen is that the filter for third-party managed apps also included Ubisoft games that need the ubisoft launcher (heroic can only install old versions of those games that always need an update during the first run) but it's fine if we do that at another point too |
…uncher into feat/epic-ea
Actually you can use the filter I added for third-party apps in Heroic. Notice Ubisoft isn't there, as Ubisoft's integration is completely different. |
right, I meant that I expected that new filter to include Ubisoft games, even though the integration is different it's mostly managed by the ubisoft launcher (heroic can install the game, but then updates, launching, saves, etc, it's all done by the ubisoft launcher at the end, so technically it's managed by ubisoft, not really managed by heroic, or managed by both) maybe at some point I make a PR for that, not really something needed or urgent though |
I see what you mean. For Ubisoft we get the possibility that Epic downloads the game files. Like you mentioned after that initial download Ubisoft Connect takes over. I think this is a matter of discussion where do we draw that |
I’m trying to get dragon age to work. Can you please tell which is the exact "legendary build with the fix from the legendary repo" that you used? |
I built the AppImage version of Heroic Game Launcher from the branch feat/epic-ea. I also built the latest git commit of legendary derrod/legendary@7fefdc4 and registered it into Settings --> Advanced --> Alternative Legendary Binary. Outdated comments
EDIT: Openend the settings of the game in Heroic and pressed run exe on prefix "/drive_c/Program Files/Electronic Arts/EA Desktop/EA Desktop/EADesktop.exe"
EDIT: found the legendary fix at derrod/legendary#632 |
do you still need the steps? I see you found the binary (you don't need to build the code from source, all binaries are automatically generated for each PR) |
Yes, this branch works for installing EA Games Launcher and the fixed legendary allows to run it and install the game within that. |
those errors seem unrelated to this PR, for help with that you should ask in Discord (join discord and create a thread in |
This enables support for EA games in Heroic by installing EA App in wine prefix when needed.
We still need to see how this all behaves with Mac native games. At the moment only Windows titles are taken care of
Use the following Checklist if you have changed something on the Backend or Frontend: