-
-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI/UX] Improve sidebar #3671
base: main
Are you sure you want to change the base?
[UI/UX] Improve sidebar #3671
Conversation
Codecheck failed within |
I wouldn't remove one thing I tried to do in #3544 is to actually add new CSS variables (or improve names) to allow easier customization by themes but adding fallbacks for better defaults when themes don't define something I'm not 100% sure about items in an accordion, I know layout shifts can be considered bad for accessibility, I don't have a strong opinion but I also understand there can be concerns about that change |
As for the divider, sorry! 😬 I will rebase it and use it as you suggested. As for the Accorion. It's not like the layout did not shift before. I agree that layout shifting is bad, but (in my opinion) it's better when it at least has an animation. But valid point, maybe someone will come with a better solution (context menu?). |
This PR is an attempt to de-clutter sidebar and improve it's readibility.
Wating for #3544 and then will rebase this on top of that
Toy can review and QA this UI-wise, but code complexity should be reduced thanks to the mentioned PR
Most notable changes:
Accordion
:focus-visible
, so navigation with gamepad should be workingdanger
colorSidebarLinks
got split intoMainLink
andExtraLinks
runner
andappname
state fromSidebarLinks
(MainLink
) since game settings are using modal for quite some time (It was dead code)--divider
css variable as it was available only in one theme and used only by dividers on the sidebar (other dividers through the heroic do no use it), now relying on--neutral-*
sidebar.webm
Use the following Checklist if you have changed something on the Backend or Frontend: