Skip to content

Commit

Permalink
[Fix/Tech] Fixup Snap publishing in build-base workflow (#3223)
Browse files Browse the repository at this point in the history
* Fixup variable name

* Set fail-fast to false

This prevents all builds from getting cancelled if one fails
  • Loading branch information
CommandMC authored Nov 21, 2023
1 parent f5663f8 commit f1db3d6
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .github/workflows/build-base.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ on:
jobs:
build:
strategy:
fail-fast: false
matrix:
os: [windows-2022, ubuntu-22.04, macos-12]
runs-on: ${{ matrix.os }}
Expand All @@ -36,7 +37,7 @@ jobs:
sudo apt-get install --no-install-recommends -y snapcraft
yarn dist:linux Snap --publish=always
env:
SNAPCRAFT_STORE_CREDENTIALS: ${{ secrets.snapcraftEdgeId }}
SNAPCRAFT_STORE_CREDENTIALS: ${{ secrets.snapcraftIdEdge }}
if: runner.os == 'Linux' && inputs.publish-snap
- name: Build AppImage version
run: yarn dist:linux AppImage
Expand Down

0 comments on commit f1db3d6

Please sign in to comment.