Skip to content

Commit

Permalink
[UI/UX] Fix some visual issues related to logs, dialogs, and RTL layo…
Browse files Browse the repository at this point in the history
…ut (#3207)

Fix some visual issues related to logs, dialogs, and RTL layout
  • Loading branch information
arielj authored Nov 21, 2023
1 parent b95abc8 commit 32e16d4
Show file tree
Hide file tree
Showing 6 changed files with 28 additions and 6 deletions.
6 changes: 6 additions & 0 deletions src/frontend/components/UI/Sidebar/index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,12 @@
padding: var(--space-2xs) 0;
}

.isRTL .Sidebar.collapsed .SidebarItemWithSubmenu:hover .SidebarSubmenu,
.isRTL .Sidebar.collapsed .SidebarItemWithSubmenu:focus-within .SidebarSubmenu {
right: var(--sidebar-width);
left: auto;
}

.Sidebar.collapsed .SidebarItemWithSubmenu:hover .SidebarSubmenu.settings,
.Sidebar.collapsed
.SidebarItemWithSubmenu:focus-within
Expand Down
5 changes: 5 additions & 0 deletions src/frontend/index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,11 @@ body {
background: var(--accent);
}

::-webkit-scrollbar-corner,
::-webkit-resizer {
background: var(--gradient-body-background, var(--body-background));
}

.simple-keyboard {
position: absolute;
z-index: 10;
Expand Down
6 changes: 5 additions & 1 deletion src/frontend/screens/Game/GamePage/index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@
}
}

.isRTL {
&.isRTL {
.gameTools {
right: auto !important;
left: 0px;
Expand All @@ -156,6 +156,10 @@
left: auto !important;
right: 1rem;
}
.backButton {
left: auto !important;
right: 12px;
}
}

.gameConfig {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
.InstallModal__dialog {
width: 38vw;
height: fit-content;
width: 700px;
min-height: fit-content;
min-width: fit-content;
max-height: 95vh;
max-width: 80vw;
height: 90vh;
max-height: 1000px;
}

.InstallModal__dialog > .anticheatInfo {
Expand Down
3 changes: 2 additions & 1 deletion src/frontend/screens/Settings/sections/LogSettings/index.css
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,12 @@
grid-template-rows: 1fr;
column-gap: 0.5rem;
height: 25em;
width: 100%;

.log-buttongroup {
display: flex;
flex-direction: column;
width: 150px;
width: 180px;
gap: 1rem;
overflow-y: auto;
overflow-x: hidden;
Expand Down
6 changes: 5 additions & 1 deletion src/frontend/state/GlobalState.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -790,9 +790,13 @@ class GlobalState extends PureComponent<Props> {
libraryStatus,
sidebarCollapsed,
hideChangelogsOnStartup,
lastChangelogShown
lastChangelogShown,
language
} = this.state

const isRTL = RTL_LANGUAGES.includes(language)
document.body.classList.toggle('isRTL', isRTL)

storage.setItem('updates', JSON.stringify(gameUpdates))
storage.setItem('sidebar_collapsed', JSON.stringify(sidebarCollapsed))
storage.setItem('hide_changelogs', JSON.stringify(hideChangelogsOnStartup))
Expand Down

0 comments on commit 32e16d4

Please sign in to comment.