Add Scene View Overlay Toolbar

[nukeandbeans]

What this does:

• Adds a new toolbar overlay to the scene view, with buttons to add lights, and adjust user settings.

How do I use?

Press space bar while the scene view is focused, and toggle the "Dynamic Lighting" overlay to show and hide it.

What can I do with it?

• Create lights. Lots of lights.
• Bake all those lights, quickly.
• Clear those lights. Guess you didn't want them there after all, huh?

Extras:

• There is an additional toggle in the bake drop-down that allows you to turn on bounce lighting by default, for each light you place after it is turned on.
• When a light is placed, it will snap to the Unity grid, or the RealtimeCSG grid if it is present. This can be toggled.
• There is a new about window! It's fancy! With icons!
• All actions to create new lights have undo.

[Henry00IS]

Hey Fluffles, thank you for your contribution to the project! I appreciate the effort and time you've put into this.

I did notice a couple things.

On monitors without UI scaling the about dialog is very small and hard to read:

When you open the menu for other light types multiple times, it continues adding separator bars at the bottom:

The light creation options in the create menu have additional settings to set up the light sources. These options are not being applied. For example the Discoball light:

When created with the old menu:

I am using CodeMaid with default Visual Studio formatting. Please use the same coding style as the rest of the project:
CodeMaid Config.zip

Regarding the attribution comments in the code, I completely understand the desire to receive credit for your work. However, having the following comment at the top of every file:

// * * * * * * * * * * * * * * * * * * * * * *
//  Author:  Lindsey Keene (nukeandbeans)
//  Contact: Twitter @nukeandbeans, Discord @nukeandbeans
//
//  Description:
//
//  * * * * * * * * * * * * * * * * * * * * * *

Feels a bit out of place, especially on smaller files like editor resources.

I'm sure we can find a way to properly acknowledge your contributions, I like having you in the about dialog and I can even add a dedicated section in the documentation. This way, your work is recognized without the need for extensive comments throughout the codebase. What do you think?

Looking forward to your thoughts!

[Henry00IS]

This code does not compile on Unity 2020 because it's using C# 9.0 features.

LinkButton discordButton = new(); // Feature 'target-typed object creation' is not available in C# 8.0. Please use language version 9.0 or greater.

But also because it doesn't yet know UnityEditor.Overlays and UnityEditor.Toolbars etc. as such it may be worth putting them in 2021 or newer conditional compilation. We do not have to drop support just yet, when we simply use the existing menu code in older versions.

Also Unity objects should not use coalescing assignment, the ??= operator. It will throw warning UNT0023 and does not work the way you expect (DynamicLightingEditorResources).
https://nosuchstudio.medium.com/why-are-null-coalescing-operators-evil-in-unity-16f5a88d6071

[Henry00IS]

Thank you so much Fluffles! This is a big quality of life improvement! 😁