-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full support pipes #217
base: master
Are you sure you want to change the base?
Full support pipes #217
Conversation
I'm not sure if it's worth spending much time with Bdsh which is planned to be replaced, but it would make sense if you would be able to sort out the potential VFS issues that (supposedly) prevent UNIX-style pipes (not DOS-style pipes) to be implemented. If I understand correctly, you have implemented so far a sort of DOS-style pipe, where the first command is executed, the output is sent to /tmp/pipe, then the second command is executed with input redirected from /tmp/pipe, etc? How did you test it? The only command I could think of that can be reasonably used as a filter is "cat -s -". I tried it with < and it works (as bad as before with from x|cat -s -) but with "cat /demo.txt | cat -s -" I get an error "cannot open -". Also I would note that it would be nice to delete the temporary file. And the temporary file would be ideally created with tmpfile(), but if you need a name, you could at least generate it with tmpnam(). |
Below you can find my tests:
2-> Send the output from one program as input to another program. cat demo.txt | in2out
Actually I'm stopping test because I found a error in bdsh that it not depends by my code. |
…e JSvoboda suggestions.
With last version I checked follow example and it seems work: |
Hi @jxsvoboda, I done changes that you ask to me. |
These changes start a full pipes support.
In particular this branch introduces following commands: