Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing python tests #478

Merged
merged 2 commits into from
Dec 6, 2022
Merged

Fix failing python tests #478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
beda578
simple removal of lac without updating other dependencies
jaguillette Dec 2, 2022
408f62f
commented out chinese language tests
jaguillette Dec 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hedera/requirements/base.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ sentry-sdk~=1.3.1
rq~=1.9.0
wagtail~=2.14.1
django-lti-provider~=0.4.7
lac~=2.1.2
# lac~=2.1.2
pip-tools~=6.4.0
tqdm~=4.63.0
# Pinned protobuf to 3.20.1 because of LAC issue with protobuf 4.21.1
Expand Down
2 changes: 0 additions & 2 deletions hedera/requirements/base.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,6 @@ jmespath==0.10.0
# botocore
l18n==2021.3
# via wagtail
lac==2.1.2
# via -r hedera/requirements/base.in
nameparser==1.1.1
# via django-lti-provider
numpy==1.21.6
Expand Down
26 changes: 13 additions & 13 deletions lemmatization/tests/test_lemmatizers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,21 @@
from django.test import SimpleTestCase, TransactionTestCase
from django.test import TransactionTestCase

from ..models import FormToLemma, Lemma
from ..services.chinese import ChineseService
from ..services.latin import LatinService


class ChineseServiceTests(SimpleTestCase):
def test_service(self):
"""
Lemmatization is simple: output is simply a list with the input as the only member;
the input is not transformed, nor any additional lemmata included.
"""
text_input = "月"
self.assertEqual(
ChineseService(lang="zho").lemmatize(text_input),
[text_input]
)
# Chinese language test commented out until support for this language is enabled again.
# class ChineseServiceTests(SimpleTestCase):
# def test_service(self):
# """
# Lemmatization is simple: output is simply a list with the input as the only member;
# the input is not transformed, nor any additional lemmata included.
# """
# text_input = "月"
# self.assertEqual(
# ChineseService(lang="zho").lemmatize(text_input),
# [text_input]
# )


class LatinServiceTests(TransactionTestCase):
Expand Down
Loading