JIT: fix USHR, optimize SHR, AND, OR, XOR #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murmour
force-pushed
the
master
branch
2 times, most recently
from
657245f
to
ff36dcb
Compare
1) USHR(-1, -1) wrongly produced -1; 2) The "best_int" check is redundant for all bitwise ops except SHL; 3) SHR, USHR, AND, OR, XOR performed unnecessary tag bit juggling.
|
Hmm, this looks pretty good actually for the USHR change... but I'm not brave enough to merge it. Will let it sit open for now. |
|
Just an anecdote: I've been using this code in production for 5+ years, with zero problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
best_intcheck is redundant for all bitwise ops except SHL;