Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typos #1166

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed typos #1166

wants to merge 2 commits into from

Conversation

NeeEoo
Copy link

@NeeEoo NeeEoo commented Dec 10, 2024

Also added -nocolour due to HXCPP_NO_COLOUR

If there are any typo's you would want me to revert, please do mention below or in a code review, or push a commit to revert that typo

Edit:
i noticed that HXCPP_NO_WASM_EXEPTIONS has a typo
and _hx_reslove_virtual_array also

Also added -nocolour due to HXCPP_NO_COLOUR
@NeeEoo NeeEoo marked this pull request as draft December 10, 2024 04:21
include/Array.h Outdated Show resolved Hide resolved
@@ -1,5 +1,5 @@
#ifndef HX_STD_STRING_INCLUDEDED
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol...

@Simn
Copy link
Member

Simn commented Dec 10, 2024

Wow... It's scary how many typos there are. Thanks a lot for looking into this!

@skial skial mentioned this pull request Dec 10, 2024
1 task
@Aidan63
Copy link
Contributor

Aidan63 commented Dec 12, 2024

Do we want to fix typos in the sljit_src folder? That's just vendored sljit source like the other libs in the project/thirdparty folder.

@Aurel300
Copy link
Member

Aurel300 commented Dec 12, 2024

Most of the docs changes should be made to the Haxe manual here. I think most of the typos were already fixed in HaxeFoundation/HaxeManual#426 but there are some that I missed (e.g. setOnFrameCallack).

@NeeEoo
Copy link
Author

NeeEoo commented Dec 12, 2024

Do we want to fix typos in the sljit_src folder? That's just vendored sljit source like the other libs in the project/thirdparty folder.

i mean its not included in the .gitattributes as a linguist-vendored so i didnt think of that

@NeeEoo NeeEoo marked this pull request as ready for review December 12, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants