Add string interpolation #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add some unit tests for it in |
|
I ran into a problem with string interpolation inside another ( |
|
Do we really want this in hscript? String interpolation is an order of magnitude more complex than everything else, especially when it starts being nested. We haven't even solved that in the compiler properly. |
|
I guess I'll just leave it unsolved. |
DleanJeans
force-pushed
the
string-interpolation
branch
from
b92e8a8
to
9b53b4b
Compare
|
Will this be merged any time soon? If not, at least I can leave it as a feature in my hscript-plus. |
|
Unless it's well tested and compliant with Haxe I think it shouldn't be merged. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #61
This passes all the tests I wrote over DleanJeans/hscript-plus.
Let me know if there's something wrong!