Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[std/hl] move some hl.Format into lib format/heaps #11869

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

yuxiaomao
Copy link
Contributor

@yuxiaomao yuxiaomao commented Dec 11, 2024

This PR address the problem that some hl.Format function should not exist in std.
The idea is to split hl.Format functions into 3 types:

I don't know if it's ok to remove totally these functions so I just declared them deprecated.

@Simn
Copy link
Member

Simn commented Dec 11, 2024

I would prefer removing this, there's a roughly 100% chance that you guys were the only ones using it anyway.

@kLabz
Copy link
Contributor

kLabz commented Dec 11, 2024

I would prefer removing this, there's a roughly 100% chance that you guys were the only ones using it anyway.

Well, heaps uses some of these so I'm not sure about this 🤔
(it's probably fine either way, especially if heaps is updated quickly)

@yuxiaomao
Copy link
Contributor Author

If the changes is validated, I'll make sure to merge some heaps PR at the same time.

@Simn
Copy link
Member

Simn commented Dec 11, 2024

Consider them validated.

@skial skial mentioned this pull request Dec 11, 2024
1 task
@yuxiaomao yuxiaomao merged commit da84165 into HaxeFoundation:development Dec 12, 2024
51 checks passed
@yuxiaomao yuxiaomao deleted the dev-hlformatsplit branch December 12, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants