Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix C standard inconsistencies #563

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

tobil4sk
Copy link
Member

@tobil4sk tobil4sk commented Sep 25, 2022

Enables standards conformance in Visual Studio solution, and fixes violating code found in dx12.cpp (which was inconsistent with directx.cpp anyway). Also makes C standard consistent between build systems (all now use C11, whereas in VS this was not set and thus defaulted to "Legacy MSVC" standard).

Here the standards conformance option is explained:
https://learn.microsoft.com/en-us/cpp/build/reference/permissive-standards-conformance?view=msvc-170

@tobil4sk tobil4sk force-pushed the conform branch 2 times, most recently from c2b87fd to 8e1dc10 Compare February 2, 2023 10:55
This avoids Compiler Error C2440

This is consistent with directx.cpp, which already conforms to the
stricter standards
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant