Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fullscreen button to demos #259

Merged
merged 3 commits into from
Mar 31, 2024

Conversation

ninjamuffin99
Copy link
Member

closes issue from HaxeFlixel/flixel-demos#322 (only closes it fully once PR HaxeFlixel/flixel-demos#336 in flixel-demos is merged!)

adds a fullscreen button that fullscreens the iframe of a demo

@ninjamuffin99 ninjamuffin99 merged commit 4a20bd9 into HaxeFlixel:dev Mar 31, 2024
5 checks passed
@Geokureli
Copy link
Member

Geokureli commented Apr 1, 2024

Hey! i've been busy this last week, what with Jesus resurrecting and what-not.

I'm cool with all this, no complaints, but I would prefer the full screen button be somewhere other than on top of the game, I have a feeling this current location will get in the way for some demos, or might be limiting for future demos

No rush tho, and I greatly appreciate the changes you're making, lately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants