High level of Nano Contracts #31
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msbrogli
force-pushed
the
feat/nano-contracts
branch
8 times, most recently
from
67823c9
to
bbea8c9
Compare
msbrogli
force-pushed
the
feat/nano-contracts
branch
from
bbea8c9
to
196464e
Compare
| └─────────────────────┴──────────────────────────────────────┘ | ||
| </pre> | ||
|
|
||
| Finally, a simple call to a method is similar to a deposit or withdrawal but with amount zero. |
There was a problem hiding this comment.
Will we have methods that can be only used in the tx inputs and others in the outputs? Should it be explicit in the blueprint?
collect_prize is a method just like make_a_bet or any other method that can be called with amount 0. How can we know where they are allowed? Does it make sense to have a method with amount 0 called in the inputs?
|
|
||
| @public | ||
| def set_result(self, result: str) -> None: | ||
| """Set result. Used by the oracle.""" |
There was a problem hiding this comment.
Only the oracle can call this? Would be interesting if anyone can call it, as long as the message is properly signed by the oracle.
msbrogli
force-pushed
the
feat/nano-contracts
branch
2 times, most recently
from
8f2638f
to
bb8527c
Compare
msbrogli
force-pushed
the
feat/nano-contracts
branch
from
bb8527c
to
2d89a4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered