Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tx-template api #518

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat: tx-template api #518

wants to merge 4 commits into from

Conversation

r4mmer
Copy link
Member

@r4mmer r4mmer commented Jan 8, 2025

Acceptance Criteria

  • Create an API to send transactions from a tx-template
  • Create an API to build transactions from a tx-template

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@r4mmer r4mmer self-assigned this Jan 8, 2025
@r4mmer r4mmer requested a review from pedroferreira1 as a code owner January 8, 2025 16:40
@r4mmer r4mmer changed the title feat: tx-template route feat: tx-template api Jan 8, 2025
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 33.89831% with 39 lines in your changes missing coverage. Please review.

Project coverage is 86.74%. Comparing base (1d1c899) to head (1e27f26).

Files with missing lines Patch % Lines
...llers/wallet/tx-template/tx-template.controller.js 17.50% 28 Missing and 5 partials ⚠️
src/helpers/validations.helper.js 14.28% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #518      +/-   ##
==========================================
- Coverage   90.19%   86.74%   -3.45%     
==========================================
  Files          54       56       +2     
  Lines        2325     2384      +59     
  Branches      439      444       +5     
==========================================
- Hits         2097     2068      -29     
- Misses        211      286      +75     
- Partials       17       30      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* LICENSE file in the root directory of this source tree.
*/

const { SendTransaction, WalletTxTemplateInterpreter, TransactionTemplate } = require('@hathor/wallet-lib');

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused variable WalletTxTemplateInterpreter.
* LICENSE file in the root directory of this source tree.
*/

const { SendTransaction, WalletTxTemplateInterpreter, TransactionTemplate } = require('@hathor/wallet-lib');

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused variable TransactionTemplate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress (WIP)
Development

Successfully merging this pull request may close these issues.

1 participant