Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Upgrades to Redux Toolkit #384

Merged
merged 20 commits into from
Feb 20, 2025
Merged

feat: Upgrades to Redux Toolkit #384

merged 20 commits into from
Feb 20, 2025
+118 −158

Conversation

tuliomir
Copy link
Contributor

@tuliomir tuliomir commented Feb 6, 2025 •
edited
Loading

This PR upgrades the Redux version of this application from v4 to v5, but instead of keeping it a direct dependency, replaces it with @reduxjs/toolkit, as strongly recommended by the Redux docs.

A similar PR was done for the desktop wallet recently.

Acceptance Criteria

  • Upgrades the Redux dependency
  • Refactors the actions and reducers code in line with the current recommendations for Redux
  • Removes a duplicate route on App.js

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@tuliomir tuliomir added the dependencies Pull requests that update a dependency file label Feb 6, 2025
@tuliomir tuliomir self-assigned this Feb 6, 2025
@tuliomir tuliomir requested a review from r4mmer as a code owner February 6, 2025 13:22
r4mmer
r4mmer previously approved these changes Feb 7, 2025
View reviewed changes
pedroferreira1
pedroferreira1 previously approved these changes Feb 18, 2025
View reviewed changes
Base automatically changed from feat/router-v6 to master February 19, 2025 22:05
@tuliomir tuliomir dismissed stale reviews from pedroferreira1 and r4mmer February 19, 2025 22:05

The base branch was changed.

@tuliomir tuliomir merged commit 0d9c4fe into master Feb 20, 2025
1 check passed
@tuliomir tuliomir deleted the feat/redux-toolkit branch February 20, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedroferreira1 pedroferreira1 pedroferreira1 approved these changes

@r4mmer r4mmer r4mmer approved these changes

Assignees

@tuliomir tuliomir

Labels
dependencies Pull requests that update a dependency file
Projects
Hathor Network
Status: Waiting to be deployed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tuliomir @pedroferreira1 @r4mmer