Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Upgrades react-router to v6 #383

Merged
merged 10 commits into from
Feb 19, 2025
Merged

feat: Upgrades react-router to v6 #383

merged 10 commits into from
Feb 19, 2025

Conversation

tuliomir
Copy link
Contributor

@tuliomir tuliomir commented Feb 3, 2025 •
edited
Loading

This PR upgrades the React Router from version 5.x to v6. Below are the guides followed to implement the necessary adaptations:

Acceptance Criteria

Notes

  • Most of the file changes were due to renaming all instances of useHistory to useNavigate on the screens.
  • For a smaller scope and easier reviewing, the available future proofing flags will not be implemented in this PR, despite being available at the current version.

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@tuliomir tuliomir added the dependencies Pull requests that update a dependency file label Feb 3, 2025
@tuliomir tuliomir self-assigned this Feb 3, 2025
@tuliomir tuliomir requested a review from r4mmer as a code owner February 3, 2025 16:04
pedroferreira1
pedroferreira1 approved these changes Feb 18, 2025
View reviewed changes
src/App.js
Comment on lines +141 to +148
<Route
path="/token_balances"
element={<NavigationRoute internalScreen={TokenBalancesList} />}
/>
<Route
path="/token_balances"
element={<NavigationRoute internalScreen={TokenBalancesList} />}
/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this duplicated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it is. This was fixed in a later PR through a2a2dff

@tuliomir tuliomir merged commit dfd320c into master Feb 19, 2025
1 check passed
@tuliomir tuliomir deleted the feat/router-v6 branch February 19, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedroferreira1 pedroferreira1 pedroferreira1 approved these changes

@r4mmer r4mmer r4mmer approved these changes

Assignees

@tuliomir tuliomir

Labels
dependencies Pull requests that update a dependency file
Projects
Hathor Network
Status: Waiting to be deployed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tuliomir @pedroferreira1 @r4mmer