refactor: using transactions count from the token entry instead of the tokenInformation API #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreabadesso
changed the title
…nt instead of transactions
andreabadesso
commented
Aug 19, 2022
| <p><b>Total number of transactions:</b> { helpers.renderValue(this.state.transactionsCount, true) }</p> | ||
| )} | ||
|
|
||
| {(this.state.tokensApiError || this.state.tokenBalanceInformationError) &&( |
There was a problem hiding this comment.
Hides the failed request data and displays a single error message for both
pedroferreira1
previously approved these changes
Aug 19, 2022
andreabadesso
force-pushed
the
refactor/get-transactions-count-from-token
branch
from
7063b34 to
d4965c6
Compare
pedroferreira1
previously approved these changes
Aug 19, 2022
pedroferreira1
approved these changes
Aug 22, 2022
r4mmer
reviewed
Aug 23, 2022
| )} | ||
|
|
||
| {(this.state.tokensApiError || this.state.tokenBalanceInformationError) &&( | ||
| <ErrorMessageWithIcon message='Error loading the complete token balance information. Please try again.' /> |
There was a problem hiding this comment.
Should we add a "Reload" button to try again?
There was a problem hiding this comment.
We could, it would be specific for the hathor token though (so is this error message)
I would just suggest opening an issue for this instead of doing it in this PR so we can merge this and fix the bug in production
r4mmer
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
transactionscolumn from the token entry retrieved from the search to display the total number of transactions for a given tokenSecurity Checklist