Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clear obsolete node cache data #52

Merged
merged 3 commits into from
Jul 28, 2021
Merged

fix: clear obsolete node cache data #52

merged 3 commits into from
Jul 28, 2021

Conversation

justgigio
Copy link
Contributor

@justgigio justgigio commented Jul 21, 2021 •
edited
Loading

TODO

  • Clear current Redis data

@justgigio justgigio changed the title fix: clean obsolete node cache data fix: clear obsolete node cache data Jul 21, 2021
@justgigio justgigio linked an issue Jul 21, 2021 that may be closed by this pull request
Remove obsolete network data from Redis #39
Closed
@justgigio justgigio self-assigned this Jul 21, 2021
pedroferreira1
pedroferreira1 approved these changes Jul 21, 2021
View reviewed changes
Copy link
Member

@pedroferreira1 pedroferreira1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR for me is good, I was just curious about the ttl as 5 seconds. I feel is too fast to delete some data when the node might just lose some connection for a few seconds. Maybe increase to 30 or 60 seconds. What do you think? @giovanecosta @msbrogli

Besides that I was thinking about the explorer itself. We keep polling this data when we are seeing a single peer, right? What happens if the peer data is deleted? The page will just become empty?

@justgigio
Copy link
Contributor Author

@pedroferreira1 30 seconds sounds fair enough for me.

Very good point on explorer. I've created an issue for that here: HathorNetwork/hathor-explorer#93

msbrogli
msbrogli requested changes Jul 23, 2021
View reviewed changes
@justgigio justgigio requested a review from msbrogli July 27, 2021 18:13
@justgigio justgigio merged commit 5b09475 into dev Jul 28, 2021
@r4mmer r4mmer deleted the fix/expire-node-data branch September 14, 2021 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msbrogli msbrogli msbrogli approved these changes

@pedroferreira1 pedroferreira1 pedroferreira1 approved these changes

Assignees

@justgigio justgigio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove obsolete network data from Redis
3 participants
@justgigio @msbrogli @pedroferreira1