Repository navigation
Conversation
Move the AI-review `repo-specific-checks` block out of claude-review.yml so it survives the planned deletion of the CI review workflows (HarperFast/.github-private#8). The workflows are untouched. Two statements in the block were stale and are corrected: the redirects bullet named historic-redirects.ts (now frozen) as the place for redirects, and the versioned-docs bullet implied v5 has versioned copies in this repo. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Dispatch-Task: documentation-review-checks-file
…w-checks Address pre-push review: CONTRIBUTING.md still allows appending a missed legacy path surfaced by analytics to historic-redirects.ts, and redirects.ts also carries release-notes rules. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Dispatch-Task: documentation-review-checks-file
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
⊙ Problem
This repo's AI-review checks live only in
claude-review.ymlandgemini-review.yml. HarperFast/.github-private#8 plans to delete those workflows, which would lose the checks. The pre-push cross-model review is switching to read.github/review-checks.mdinstead (skills-internal taskskills-internal-review-layers-in-house), so the file must exist here.💡 Solution
Adds
.github/review-checks.md:layers: universalfrontmatter plus the workflows'repo-specific-checksblock, dedented. The workflows are untouched and keep their own copy. Nothing in this repo reads the new file, so merging it changes no behavior here; it is safe to merge before the skills-internal reader lands.The
claude-review.ymlandgemini-review.ymlblocks are byte-identical (compared withcmp), as are theirreview-layers, so no union was needed.universalmatches both.🤔 The workflows still carry the old text
Two bullets below were corrected only in the new file; the workflows keep the stale versions until #8 deletes them. I left them because the task says the workflows change in a separate PR.
🔧 Changes
Everything is copied as written except two bullets that were no longer true of this repo:
currentis v5, which is assembled from harper and harper-pro at build time, and the only snapshot is the archived v4 inreference_versioned_docs/version-v4/.AGENTS.mdsays v5 work must not edit that directory. The bullet now says that.historic-redirects.tskeeps old URLs alive. That file is frozen and append-only (historic-redirects.ts:10,CONTRIBUTING.md). New rules go inredirects.tsfor pages this repo owns (Learn, Fabric, release notes) or indocs/reference/_redirects.jsonin harper or harper-pro for v5 reference pages. The bullet now says that and keeps the one allowed exception: a missed legacy/docs/4.X/*path that analytics surfaced.The tooling bullet (
typecheck,format:check,lint, assembled v5 content) was checked againstpackage.jsonandAGENTS.mdand is unchanged. The block never mentions storage engines, so there was nothing to correct there.🤔 The tooling bullet does not mention
npm run buildornpm run test:workflowsAGENTS.mdcalls the build the best end-to-end check. I kept the bullet as copied: it says nothing false, and adding checks is new content, not a correction.✅ Verification
Not observable in this repo; the skills-internal PR's tests cover the reader. Checked here:
npx prettier --check .github/review-checks.mdpasses; the new body matches the workflow block except for the two bullets above (diffagainst the dedented block); the workflows are untouched (git diff origin/main -- .github/workflowsis empty).🤖 Generated by Anthropic Claude (Sonnet 5.5); posted via @kriszyp.
Related PRs: none found
Complexity: easy
Accepted behavior
Behavior the owner ruled intended, so there is nothing to file.
2 minor or nit
90cc4f6ac24ac5a4nit documentation —.github/workflows/claude-review.yml— Workflow review-check blocks keep the stale versioned-docs and redirects bullets this PR corrects — accepted: task owner kriszyp, dispatch task documentation-review-checks-file ("Do NOT delete or edit the workflows; that is a separate PR")a62e3b0ffd9578b8nit documentation —.github/review-checks.md— Tooling bullet omits npm run build and test:workflows named by AGENTS.md — accepted: task owner kriszyp, dispatch task documentation-review-checks-file ("Copy faithfully, but correct statements that are now false")Origin — the dispatch brief this PR was written from
Add
.github/review-checks.md, moving this repo's AI-reviewrepo-specific-checksblock out of.github/workflows/claude-review.ymlso it survives the planned deletion of the CI review workflows (HarperFast/.github-private#8). Do NOT delete or edit the workflows; that is a separate PR. Open a draft PR.Acceptance
One new file
.github/review-checks.mdin the format above; workflows untouched. PR body: why (link .github-private#8), the dependency on skills-internal-review-layers-in-house, any gemini/claude block differences and any corrections. Verification route: not observable in this repo; the skills-internal PR's tests cover the reader.Dispatch: task
documentation-review-checks-file· queued by kris-session/ai-review-retirement · ran by claude/sonnet/xhigh · worker kris-mac-m3-fleet-18b9c6Ready-For-Promotion: f184db0 urgency=normal late=none
Review-Coverage: authored=claude; ran=cursor-composer,codex,gemini; adjudicated=domain; declined=cursor-grok,muse; rounds=3; full=1 @ f184db0
Review-Attention: skim ~2m (decisions: leave-workflow-blocks-stale, historic-redirects-policy-source) @ f184db0