Skip to content

Add .github/review-checks.md so the AI-review checks outlive the CI review workflows - #807

Draft
kriszyp wants to merge 2 commits into
mainfrom
chore/review-checks-file
Draft

kriszyp wants to merge 2 commits into
mainfrom
chore/review-checks-file

Conversation

@kriszyp

@kriszyp kriszyp commented Nov 10, 2026 •

Copy link
Copy Markdown
Member

⊙ Problem

This repo's AI-review checks live only in claude-review.yml and gemini-review.yml. HarperFast/.github-private#8 plans to delete those workflows, which would lose the checks. The pre-push cross-model review is switching to read .github/review-checks.md instead (skills-internal task skills-internal-review-layers-in-house), so the file must exist here.

💡 Solution

Adds .github/review-checks.md: layers: universal frontmatter plus the workflows' repo-specific-checks block, dedented. The workflows are untouched and keep their own copy. Nothing in this repo reads the new file, so merging it changes no behavior here; it is safe to merge before the skills-internal reader lands.

The claude-review.yml and gemini-review.yml blocks are byte-identical (compared with cmp), as are their review-layers, so no union was needed. universal matches both.

🤔 The workflows still carry the old text

Two bullets below were corrected only in the new file; the workflows keep the stale versions until #8 deletes them. I left them because the task says the workflows change in a separate PR.

🔧 Changes

Everything is copied as written except two bullets that were no longer true of this repo:

  • Versioned docs. The old text said a fix to the "current version" leaves "versioned copies" wrong. Here, current is v5, which is assembled from harper and harper-pro at build time, and the only snapshot is the archived v4 in reference_versioned_docs/version-v4/. AGENTS.md says v5 work must not edit that directory. The bullet now says that.
  • Redirects. (look hardest here) The old text said historic-redirects.ts keeps old URLs alive. That file is frozen and append-only (historic-redirects.ts:10, CONTRIBUTING.md). New rules go in redirects.ts for pages this repo owns (Learn, Fabric, release notes) or in docs/reference/_redirects.json in harper or harper-pro for v5 reference pages. The bullet now says that and keeps the one allowed exception: a missed legacy /docs/4.X/* path that analytics surfaced.

The tooling bullet (typecheck, format:check, lint, assembled v5 content) was checked against package.json and AGENTS.md and is unchanged. The block never mentions storage engines, so there was nothing to correct there.

🤔 The tooling bullet does not mention npm run build or npm run test:workflows

AGENTS.md calls the build the best end-to-end check. I kept the bullet as copied: it says nothing false, and adding checks is new content, not a correction.

✅ Verification

Not observable in this repo; the skills-internal PR's tests cover the reader. Checked here: npx prettier --check .github/review-checks.md passes; the new body matches the workflow block except for the two bullets above (diff against the dedented block); the workflows are untouched (git diff origin/main -- .github/workflows is empty).

🤖 Generated by Anthropic Claude (Sonnet 5.5); posted via @kriszyp.

Related PRs: none found
Complexity: easy

Accepted behavior

Behavior the owner ruled intended, so there is nothing to file.

2 minor or nit
  • 90cc4f6ac24ac5a4 nit documentation — .github/workflows/claude-review.yml — Workflow review-check blocks keep the stale versioned-docs and redirects bullets this PR corrects — accepted: task owner kriszyp, dispatch task documentation-review-checks-file ("Do NOT delete or edit the workflows; that is a separate PR")
  • a62e3b0ffd9578b8 nit documentation — .github/review-checks.md — Tooling bullet omits npm run build and test:workflows named by AGENTS.md — accepted: task owner kriszyp, dispatch task documentation-review-checks-file ("Copy faithfully, but correct statements that are now false")
Origin — the dispatch brief this PR was written from

Add .github/review-checks.md, moving this repo's AI-review repo-specific-checks block out of .github/workflows/claude-review.yml so it survives the planned deletion of the CI review workflows (HarperFast/.github-private#8). Do NOT delete or edit the workflows; that is a separate PR. Open a draft PR.

Acceptance

One new file .github/review-checks.md in the format above; workflows untouched. PR body: why (link .github-private#8), the dependency on skills-internal-review-layers-in-house, any gemini/claude block differences and any corrections. Verification route: not observable in this repo; the skills-internal PR's tests cover the reader.

Dispatch: task documentation-review-checks-file · queued by kris-session/ai-review-retirement · ran by claude/sonnet/xhigh · worker kris-mac-m3-fleet-18b9c6

Ready-For-Promotion: f184db0 urgency=normal late=none

Review-Coverage: authored=claude; ran=cursor-composer,codex,gemini; adjudicated=domain; declined=cursor-grok,muse; rounds=3; full=1 @ f184db0

Review-Attention: skim ~2m (decisions: leave-workflow-blocks-stale, historic-redirects-policy-source) @ f184db0

kriszyp and others added 2 commits November 10, 2026 09:05
Move the AI-review `repo-specific-checks` block out of
claude-review.yml so it survives the planned deletion of the CI review
workflows (HarperFast/.github-private#8). The workflows are untouched.

Two statements in the block were stale and are corrected: the redirects
bullet named historic-redirects.ts (now frozen) as the place for
redirects, and the versioned-docs bullet implied v5 has versioned copies
in this repo.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Dispatch-Task: documentation-review-checks-file
…w-checks

Address pre-push review: CONTRIBUTING.md still allows appending a missed
legacy path surfaced by analytics to historic-redirects.ts, and
redirects.ts also carries release-notes rules.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Dispatch-Task: documentation-review-checks-file

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant