Entrance Names Redux #4941
Draft
Entrance Names Redux #4941
+142
−125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iate from the bosses on the other sides of boss doors. Fix some names that weren't the same in both pairs of entrances. Renamed a few other entrances for clarification.
Fix remaining non-matching names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unifies naming conventions (full area names for area exits, acronyms for interior transitions), fixes a few entrances that didn't have the same name on both pairs in the entrance tracker (man, I really want to remove the double-storage of these entrance names...), and will finish renaming as many others as we feasibly can, especially east/west directional names (to avoid mirror mode issues), as well as internal grotto entrance names to reflect what is in them rather than relying on what their entry point names are.
It's draft for now because the last part of that isn't done yet.
Build Artifacts