Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GFX Debugger support #4345

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Add GFX Debugger support #4345

merged 2 commits into from
Oct 18, 2024

Conversation

Archez
Copy link
Contributor

@Archez Archez commented Sep 15, 2024 •
edited by github-actions bot
Loading

Ports and adds support for the GFX debugger in LUS as seen in 2Ship.

  • Registers the window into our GUI
  • Activates GFX disassembly through libgfxd via CMAKE vars
  • Hooks the GFX debugger up with the game loop
  • Enables the open/close noop strings so that they are visible in the debugger

Build Artifacts

Pepe20129
Pepe20129 approved these changes Sep 15, 2024
View reviewed changes
Copy link
Contributor

@Pepe20129 Pepe20129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just a small nit.

soh/src/code/graph.c Show resolved Hide resolved
@Archez Archez marked this pull request as ready for review October 10, 2024 04:00
@Malkierian Malkierian merged commit f1841a2 into HarbourMasters:develop Oct 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pepe20129 Pepe20129 Pepe20129 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Archez @Pepe20129 @Malkierian