Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Deku Mouth for Entrance Rando and Mido Rando Functionality #4342

Merged
merged 3 commits into from
Sep 17, 2024

Conversation

Malkierian
Copy link
Contributor

@Malkierian Malkierian commented Sep 15, 2024

Restores open Deku mouth for adult in dungeon entrance shuffle. Based on either forest being open or the flag for having shown Mido the sword and shield.

Also restores Rando Mido functionality (if starting with closed Deku or Forest and Skip Child Zelda, Mido would be in his house and you couldn't flip the flag for showing him the sword and sheild. Would have messed with Deku mouth as adult).

Vanilla and VB functionality appear to be untouched.

Build Artifacts

@Pepper0ni
Copy link
Contributor

Pepper0ni commented Sep 17, 2024

Bugs found:

  • Mido does not respect the kokiri draw distance enhancement EDIT: only seems to be broken when using a debug file
  • If forest is open, skip child zelda is off, and the player has magic (easily testable via a debug save), then the first time a player enters kokiri forest proper they will be unable to pause until they leave or talk to someone. If this is the initial spawn the state will be signified by the magic bar not loading, but will occur even if it has already loaded.
  • If the player spawns next to deku tree on a new seed with a debug save file with closed deku, the mouth will be open even though mido has not yet been "talked to". a normal save file that save edits kokiri and deku shield and then goes back does not do this. This could be a side effect of the debug save.

@Malkierian
Copy link
Contributor Author

I'm not terribly worried about debug saves not working, as I don't know if there's a true "intended" for those to be compared to. Does the second issue happen without it?

@Pepper0ni
Copy link
Contributor

It does seem to be more debug jank. My bad. Debug jank might need to be cleared up long term but I can understand not wanting it to be a blocker.

@Malkierian Malkierian merged commit 6cd387d into HarbourMasters:develop-rando Sep 17, 2024
5 checks passed
@Malkierian Malkierian deleted the deku-mido-fix branch September 17, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants