Check Tracker Re-update #4322
Merged
Check Tracker Re-update #4322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pepe20129
added
code cleanup
rando v3
…d Skipped are now stored in ItemLocation, though still saved separately in the trackerData section.
Some cleanup of unused code.
Fix skipped status saving.
Malkierian
force-pushed
the
check-tracker-update
branch
from
ae6b694
to
5f4a230
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores check tracker status functionality. Part of the process was storing check status and skipped status in ItemLocation in-memory, but still saving it in a separate save section to allow for scummed status updates.
Also restores Seen and Identified functionality in the shops, check counts should be accurate, RandomizerTrackerData is no more (prices are gotten for shuffled shops also from ItemLocation), and has a couple small optimizations for debug performance surrounding the filter and the logic helper text.
The status is managed in the hook handlers and SaveManager flow now instead of being handled by the check tracker code, and as a side effect of using what used to be the
HasObtainedstructure, the tracker now only shows what was in checks when the item is received rather than when when the check flag was changed.Build Artifacts