WIP: Silver Rupee Shuffle #4028
Conversation
Remaining locations yet to be added, but the ones that were added are working.
…pwright into rando-silver-rupee-shuffle
…pwright into rando-silver-rupee-shuffle
1. Fixed Ganon Non-hint text from loading as Saria's Magic Hint. 2. Fixed Ganon Non-hint text from not getting saved correctly. 3. Fixed gossip stone hint generation from not generating any non-always hints on No Logic. For #3, the hint distribution and placement algorithm was bailing out too early when it wasn't able to place a hint. For No Logic, what it was doing was failing to place WOTH hints (since No Logic seeds don't calculate WOTH candidacy), returning the amount of hints it failed to place, and then it called the function to redistribute the hints, but did not call the function to attempt to place the remaining hints. Additionally, it was not accounting for the fact that we shouldn't redistribute the hints into the categories we failed to place a hint in, so it would redistribute hints right back into those categories. I changed it so that when DistributeHints gets called after PlaceHints fails to place the hint, it checks if the distribution settings copies attribute was set to 0. In this case, it breaks while looping for the type distribution settings, and moves on to the next category. Also, it now repeatedly attempts to distribute and place hints until PlaceHints returns 0 (meaning it placed all of its hints successfully).
…pwright into rando-silver-rupee-shuffle
…pwright into rando-silver-rupee-shuffle
| /* */ RandomizerGet rg; | ||
| /* */ GetItemEntry* giEntry; | ||
| /* */ RandomizerInf randInfFlag; |
There was a problem hiding this comment.
Could you not derive these 3 from just storing the RC?
There was a problem hiding this comment.
Well, the randomizer get is for the Silver Trackers, not Silver Rupees. That rando get is for identifying which room it's for. It's get a little messy since the rupees and the tracker share an actor type.
The other two I store after deducing them once because if I don't store them somewhere I have to deduce again every frame for the drawing and update functions to work properly.
There was a problem hiding this comment.
You would know better than me actually, is there a good place to store them with the hook setup without extending the vanilla struct like this?
|
Been testing this and ran into trouble with the GTG boulder room. It's probably not a coincidence that it's the first room to give me trouble when it's also the only one to have special cased behavior. The weird part is that simulating the non-special behavior with the flags editor somehow fixed it. (As in opening the door; it didn't cancel the timer.) P.S. The changes to CustomMessageManager.h seem to have broken hint formatting. Aside from those two issues (and the lack of logic and item tracker support), this patch works very well! |
|
Potentially a more significant issue than the lack of logic: even if silver rupees are set to vanilla, they can still have items placed in their locations, and potentially required items that the seed can't be beaten without. They still spawn as vanilla in their respective dungeons, so while their room can be completed, those important items can become unobtainable. |
…pwright into rando-silver-rupee-shuffle
Wanted to get a Draft PR up for this so it could get some more field testing.
What's in so far:
Left to be done:
Build Artifacts