Rework package #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Small object that can determine if an string/character is in Arabic.
Implemented automation for unit testing to prevent broken commits into the project.
… the GitHub automation do it's things and test the project.
…ns errors for uneven Swift tool version.
…e package functionality on my own machine.
Co-Authored-By: Seyed Mojtaba Hosseini Zeidabadi <[email protected]>
Mohammad's original commit: r - extract linesProcessing Co-Authored-By: Mohamad Rahmani <[email protected]>
Mohammad's original coomit: r - use CharacterSet newlines instead of hardcoding newline + use components String's method and return an actual Array of String instead of a Substring (since you'll need to convert that again). Co-Authored-By: Mohamad Rahmani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposing to rework branch based on observations.
Main key achievements:
This PR will introduce some objects/logics which is listed below:
Characters
Character objects will encapsulate bridge between
Farsijustification and code implementation.CoreTextExtendible
Small weight objects (
Line,Word) that will contain logics for re-aligning the given string.Arabic evaluator