-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: updated the docs for this [PR](https://github.com/HaoboGu/rmk-… #215
Conversation
462e84f
to
606128f
Compare
Thanks a lot! There are some minor issues, we can get it merged after fixing them. |
Alright, what issues are you referring to specifically? |
I'm not able to see anything like that. Only the comments on this page. It looks like your Reviews are pending. I'm not too familiar with GitHub, but do you maybe need to commit or finish your review before others will be able to see it? |
Regarding the first one: Regarding the second one: |
oh I forgot to submit the review, sorry for that! |
Got it. let's update it to |
8461ec9
to
3e21910
Compare
"-f", | ||
"0x2dc309c5", # Use your chip family ID in the uf2conv.py file as -f argument | ||
"-o", | ||
"--family", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong argument
pls fix the ci error then I can merge it |
Great work! I'm merging it, thanks a lot! |
There's something we can do to improve it, for example, releasing the cargo-hex-to-uf2 binary so that we can use |
This is an update to the docs for this pull request.