Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combos support #152

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Combos support #152

wants to merge 12 commits into from
+666 −141

Conversation

pcasotti
Copy link
Collaborator

@pcasotti pcasotti commented Nov 23, 2024 •
edited
Loading

Closes #117

  • Implement basic functionality
  • Add configuration options
  • Add Vial support
  • Move behind a feature flag (maybe)
  • Support COMBO_{ON/OFF/TOGGLE} keycodes
  • Allow limiting a combo to a specific layer
  • Layer independent combos
  • Update relevant documentation
  • Save combos in flash
  • Add cmb! macro for easy combo declaration in rust

@pcasotti
Copy link
Collaborator Author

Almost working, still not 100%

@HaoboGu
Copy link
Owner

HaoboGu commented Nov 24, 2024

I got a little bit busy recently, so I invited you as the repo member. Feel free to review and merge PRs when you want. :D

@pcasotti
Copy link
Collaborator Author

I got a little bit busy recently, so I invited you as the repo member. Feel free to review and merge PRs when you want. :D

Thank you so much!

@pcasotti pcasotti force-pushed the feat/combo branch 2 times, most recently from 7c12e2f to 256952c Compare November 28, 2024 13:53
@pcasotti
Copy link
Collaborator Author

pcasotti commented Dec 18, 2024 •
edited
Loading

  • Find a way to remove duplicate COMBO_MAX_NUM and COMBO_MAX_LENGTH
  • Fix inconsistent use of vec and array
  • Fix vial communication with different values of COMBO_MAX_LENGTH
  • Fix timeout

@w-jablonski
Copy link

Would you kindly consider my request #55 (Btw when I write "Chord" I mean "Combo")

@HaoboGu
Copy link
Owner

HaoboGu commented Dec 26, 2024

  • Find a way to remove duplicate COMBO_MAX_NUM and COMBO_MAX_LENGTH

It seems that we need rmk-config again? 😅

@pcasotti
Copy link
Collaborator Author

It seems that we need rmk-config again? 😅

Well.. this is a soluton, we could then use it for NUM_MACRO and other constants if we want to access them in rmk-macro. I'm still not entirely convinced this is the best option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Combos support
3 participants
@pcasotti @HaoboGu @w-jablonski