wip: Feat/refactor #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexH-HankIT
force-pushed
the
feat/refactor
branch
6 times, most recently
from
71e5e8b to
0923514
Compare
AlexH-HankIT
force-pushed
the
feat/refactor
branch
14 times, most recently
from
897b93a to
0ee4055
Compare
Add event system to BaseRequest with loading event support Introduced an event system to `BaseRequest` to enable custom event handling. Added `RequestEvents` enum to define supported events, starting with a `LOADING` event. Updated `send()` method to dispatch loading events, enhancing extensibility and improving state management. Refactor BaseRequest to support generics and improve flexibility Added generic type parameters to `BaseRequest` for enhanced type safety and configurability. Introduced strongly typed parameter handling in `setParams` and `withParams` methods. Improved structure and maintainability while preparing the request system for more robust use cases. Add event system to BaseRequest with loading event support Introduced an event system to `BaseRequest` to enable custom event handling. Added `RequestEvents` enum to define supported events, starting with a `LOADING` event. Updated `send()` method to dispatch loading events, enhancing extensibility and improving state management. Refactor service layer contracts and improve type safety Reorganized service layer to replace class-based ResponseError with type-safe interfaces and optional properties. Improved error handling logic consistency and added stricter type annotations throughout. These changes enhance maintainability, align with modern TypeScript practices, and improve code clarity. Refactor request/response architecture for clarity and extensibility Streamlined request/response handling by introducing type-safe interfaces, improving error handling, and replacing redundant classes. Deprecated `ResponseDto` and similar constructs in favor of improved abstraction via handler contracts. These changes adhere to better TypeScript patterns for extensibility and maintainability.
AlexH-HankIT
force-pushed
the
feat/refactor
branch
from
0ee4055 to
4d86bd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.