Add channel flag to de-select by default on versions page #1255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Machine-Maker
commented
Jul 29, 2023
Comment on lines
27
to
18
| const frozen = props.channel && props.channel.flags.includes(ChannelFlag.FROZEN); | ||
| const possibleFlags = frozen ? [ChannelFlag.PINNED] : [ChannelFlag.UNSTABLE, ChannelFlag.PINNED]; | ||
| const possibleFlags = frozen ? [ChannelFlag.PINNED] : [ChannelFlag.UNSTABLE, ChannelFlag.PINNED, ChannelFlag.HIDE_BY_DEFAULT]; | ||
|
|
There was a problem hiding this comment.
I'm not really a fan of this hardcoded flags based on frozen. Probably should be part of the backend data, what channel flags are valid when frozen or not, but that's a separate PR.
kennytv
approved these changes
Aug 14, 2023
MiniDigger
force-pushed
the
feature/channel-deselect-flag
branch
from
b02e63d
to
5356b81
Compare
MiniDigger
force-pushed
the
feature/channel-deselect-flag
branch
from
5356b81
to
5c07353
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsure about the name, or maybe it should be defaulted to on and flipped?