Better tests for matrix multiplication in solutions for exercise 8 #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added overloads for 'error' and 'results' with two matrices being compared for equality. Changed matrix initializations from constant values to non-constant ones. Stored the result from the sequantial host-based matrix multiplication in a separate array for later comparison.
It seems that the previous version was computing a transposed result. This change made the execution on my machine 4 times slower -- no clue why. But it passes the test.
…more rigorous testing of the results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified initialization and comparison functions in C, Cpp and Python directories for more rigorous testing of the results.