🌶️ Remove built in C dependency #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I saw that this piece of cpp code was introduced in #4 to fix x86 compatibility. Would there be any impact if it were removed? |
|
I wouldn't expect it to, what is causing the x86 compat is the function call. We need to manually load the dll and query the entrypoint because it doesnt always exist. All of this can just easily be done from Rust just as well - which this PR does. Put another way, the actual code thats executed doesn't change with this PR, however, it's written in Rust now. |
|
Thank you. |
Hanaasagi
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not really needed to bring in bindgen and other large crates for this as we can just move the code into Rust instead to make this crate a bit leaner.