-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regenerate the default elower grid trange file #466
Conversation
…to regenerate_elower_trange
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much! I am so sorry for the severe delay in reviewing. I have confirmed that the test scripts work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have just added suggestions in premodit_trange.ipynb
as I thought it would be easier for the users to understand if the parameter names are the same as those used in the function definition.
addressed #345 #456
I regenerated the default elower grid trange file (degt file), which determine the robust temperature range in PreMODIT because the previous one (version=1) did not cover the temperature cooler than 100K and hotter than 5000K. The current version (version=2) extends the range to 50-7500K.
you can change the version (default=2) by setting
version_auto_trange
inOpaPremodit
.test:
tests/integration/premodit/lowtemp_optimal_trange.py
for 80Ktest:
tests/integration/premodit/hightemp_optimal_trange.py
for 6500KSee here as the doc. Note that
exojax.spec.generate_elower_grid_trange.generate_elower_grid_trange
can generate your owndegt file
.