Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate the default elower grid trange file #466

Merged
merged 15 commits into from
Jan 29, 2024

Conversation

HajimeKawahara
Copy link
Owner

@HajimeKawahara HajimeKawahara commented Jan 16, 2024

addressed #345 #456

I regenerated the default elower grid trange file (degt file), which determine the robust temperature range in PreMODIT because the previous one (version=1) did not cover the temperature cooler than 100K and hotter than 5000K. The current version (version=2) extends the range to 50-7500K.

you can change the version (default=2) by setting version_auto_trange in OpaPremodit.

test: tests/integration/premodit/lowtemp_optimal_trange.py for 80K
test: tests/integration/premodit/hightemp_optimal_trange.py for 6500K

See here as the doc. Note that exojax.spec.generate_elower_grid_trange.generate_elower_grid_trange can generate your own degt file.

@HajimeKawahara HajimeKawahara added the enhancement New feature or request label Jan 16, 2024
@HajimeKawahara HajimeKawahara added this to the v1.5 milestone Jan 16, 2024
@HajimeKawahara HajimeKawahara self-assigned this Jan 16, 2024
Copy link

github-actions bot commented Jan 16, 2024

Unit Test Results

139 tests  ±0   139 ✔️ ±0   31s ⏱️ -2s
    1 suites ±0       0 💤 ±0 
    1 files   ±0       0 ±0 

Results for commit 1de5269. ± Comparison against base commit 7d79ebd.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@ykawashima ykawashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much! I am so sorry for the severe delay in reviewing. I have confirmed that the test scripts work.

documents/userguide/premodit_trange.ipynb Outdated Show resolved Hide resolved
Copy link
Collaborator

@ykawashima ykawashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just added suggestions in premodit_trange.ipynb as I thought it would be easier for the users to understand if the parameter names are the same as those used in the function definition.

documents/userguide/premodit_trange.ipynb Outdated Show resolved Hide resolved
documents/userguide/premodit_trange.ipynb Outdated Show resolved Hide resolved
documents/userguide/premodit_trange.ipynb Outdated Show resolved Hide resolved
documents/userguide/premodit_trange.ipynb Outdated Show resolved Hide resolved
documents/userguide/premodit_trange.ipynb Outdated Show resolved Hide resolved
documents/userguide/premodit_trange.ipynb Outdated Show resolved Hide resolved
documents/userguide/premodit_trange.ipynb Outdated Show resolved Hide resolved
documents/userguide/premodit_trange.ipynb Outdated Show resolved Hide resolved
@HajimeKawahara HajimeKawahara merged commit 38401ff into develop Jan 29, 2024
3 checks passed
@HajimeKawahara HajimeKawahara deleted the regenerate_elower_trange branch January 29, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants