Comments #477
Merged
Comments #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Ignored Deployments
|
VictiniX888
requested review from
VictiniX888
and removed request for
vuvincent
VictiniX888
requested changes
Sep 14, 2023
apps/podium/app/comment/comment.tsx
Outdated
There was a problem hiding this comment.
Move this comment folder into /components/
apps/podium/app/comment/comment.tsx
Outdated
| `; | ||
| const OuterContainer = styled.div` | ||
| width: 355px; | ||
| background: #161616; |
There was a problem hiding this comment.
nit: Extract this (and all other colors) out into a const (ideally shared between components) so that we don't have random hex codes littered around the css
apps/podium/app/comment/comment.tsx
Outdated
| const Name = styled.p` | ||
| color: #9d9d9d; | ||
| font-family: SF Pro Text; | ||
| font-size: 17px; |
There was a problem hiding this comment.
nit: Use relative units (rem or em) for all font-size, and margin/padding where suitable
apps/podium/pages/comments/index.tsx
Outdated
| * Note: The corresponding styles are in the ./index.scss file. | ||
| */ | ||
| return ( | ||
| <PhoneScreen> |
There was a problem hiding this comment.
Could you add another div outside so that the background color is shown across the entire page instead of just the small strip
| padding: 30px; | ||
| justify-content: flex-start; | ||
| gap: 40px; | ||
| `; |
There was a problem hiding this comment.
Make this div centered horizontally by adding margin: 0 auto
|
Changed to fit the new style, so I made it white Can post comments, not sure where to get the user ID and project ID from so I had those hardcoded, but I’m assuming those can be retrieved from cookies so I can add that functionality later when specified Need to change how the api works so that one user can post multiple comments, how it is right now is that once a new user posts, it just overwrites that comment |
VictiniX888
added a commit
that referenced
this pull request
Nov 4, 2023
* Initialize Podium app and service * Update poetry.lock * Setup Podium DB * Setup sqlalchemy and pydantic * Implement podium service endpoints * Set up docker container for db and assoc nx commands * Add vertical admin endpoints * Refactor to Chalice + CockroachDB * Update README with run instructions * Use UUID for project and vertical IDs instead of serial * Return vertical details in project details * Add endpoint to get all projects * Add endpoint to get all rankings * Add endpoint to unlock rankings * Add video_url field to Projects * temp add projects api * Fix misc bugs and improvements * Include vertical name and ID in each project for get rankings for judge * Include description and videoUrl in each project for get all projects * Add vertical as field in request for update project details to allow changing verticals * Fix unlock vertical endpoint to not error due to not returning any rows * Delete final rankings when unlocking vertical to allow locking again * Add endpoint to get lock state of vertical * Fix /ranking endpoint error, fix lock rankings not addign final rankings * Fix delete lock would delete all final rankings * Add currentRank to get project * add add_projects route, fix logic in add_projects api * Fix add_projects api * Add judge and comments tables, add comments endpoints * Fix error on installing dependencies for podium-service * Pin nixpkgs to latest staging-next with updated typing-extensions * Implement judge endpoints * Set up vanilla-extract for podium * Initialize podium front end * Clean up code and connect judge API * Fix crash on slideroom * Fix slideroom visual bug * Added a sortable context around the spotlight project * Kept a separate local state for ranked and unranked projects * Remove active spotlight project from local list of projects * Then add onDragOver, then the spotlight project is first dragged over the project bar we add it back to the list? * Also changed the collision detection algorithm in dndcontext to use closestCorners * Add comments page for Judging Portal (#477) * basic comments section --no functionality * working with api * small fixes * post request and style changes * Make page responsive, show comment input only when press button * Fix get comments to show name * Allow users to post multiple comments * Integrate comments page with user and project context, attempt to fix slideroom desktop...? * Initialize judge fake user logic * Change format for add projects in bulk endpoints for retool * Extract image from video thumbnail * Fix bulk add projects endpoint crashing * Show youtube thumbnail correctly * Fix compile issues Huh * Add endpoint to unrank projects * Implement new project detail design * Add RBAC to podium service * Revise protected endpoints * Basic On Hold system with bug * Add master auth token method * Fix dragging out of on hold * Fix dragging from on hold to #1 * Fix drag when all are unranked bug * Clean up code * Improve UI * Fix dragging unranked into ranked * Fix dragging from on hold to unranked But cannot drag again after * Fix compile errors * Improve mobile UI * Implement comments with Link * Fix haptic touch bug * Improve comments UI and minor cursor changes * Create search feature * Change details CSS to shared modal * Fix rank to second unranked bug * Show yt thumbnail on on hold preview and project details * Fix compile error * Improve mobile responsiveness * Return all project info in get_all_projects_in_vertical * Pass auth token to API calls * Update getProjects with new API structure * Add RBAC for podium frontned Only judges can enter the website * Add RBAC for comments page too * Fix error when deleting projects, and correctly reassign ranking when changing project vertical * Add judging criteria * Remove search, move question mark button to top bar, fix project names not showing up --------- Co-authored-by: Benran Zhang <[email protected]> Co-authored-by: roryvisuals <[email protected]> Co-authored-by: Leyland Yang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
comments section components for the send comment and a comment
havent yet made the components take in input so no functionality